From: Devendra Naga Date: Sun, 16 Sep 2012 16:01:59 +0000 (-0400) Subject: staging: silicom: fix a comparing proc_dir_entry pointer against 0 X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=0c4a9f6e0ac55db62816bfa5e584ed807540a5ee;p=linux-beck.git staging: silicom: fix a comparing proc_dir_entry pointer against 0 we should be using the NULL macro, not 0 to compare against a pointer value, and also remove braces around the single if conditional after the create_proc_entry Signed-off-by: Devendra Naga Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/staging/silicom/bp_mod.c b/drivers/staging/silicom/bp_mod.c index f138d2975295..2722da91dea3 100644 --- a/drivers/staging/silicom/bp_mod.c +++ b/drivers/staging/silicom/bp_mod.c @@ -7725,10 +7725,8 @@ bypass_proc_create_entry_sd(struct pfs_unit_sd *pfs_unit_curr, S_IFREG | S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH, parent_pfs); - if (pfs_unit_curr->proc_entry == 0) { - + if (pfs_unit_curr->proc_entry == NULL) return -1; - } pfs_unit_curr->proc_entry->read_proc = read_proc; pfs_unit_curr->proc_entry->write_proc = write_proc;