From: Yan Date: Thu, 25 Oct 2007 19:48:28 +0000 (-0400) Subject: btrfs_inode_by_name return random value. X-Git-Tag: v2.6.29-rc1~27^2~9^2~55^2~56^2~30^2~435 X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=0d9f7f3e27a92b07212090a1772fdbb3a92fef81;p=karo-tx-linux.git btrfs_inode_by_name return random value. When inode is found, the return value is from the uninitialized variable 'ret'. -- Signed-off-by: Chris Mason --- diff --git a/fs/btrfs/inode.c b/fs/btrfs/inode.c index c07433072322..b74a831fab19 100644 --- a/fs/btrfs/inode.c +++ b/fs/btrfs/inode.c @@ -847,15 +847,16 @@ static int btrfs_inode_by_name(struct inode *dir, struct dentry *dentry, struct btrfs_dir_item *di; struct btrfs_path *path; struct btrfs_root *root = BTRFS_I(dir)->root; - int ret; + int ret = 0; path = btrfs_alloc_path(); BUG_ON(!path); di = btrfs_lookup_dir_item(NULL, root, path, dir->i_ino, name, namelen, 0); + if (IS_ERR(di)) + ret = PTR_ERR(di); if (!di || IS_ERR(di)) { location->objectid = 0; - ret = 0; goto out; } btrfs_dir_item_key_to_cpu(path->nodes[0], di, location);