From: Johan Hovold Date: Mon, 26 Jan 2015 11:02:45 +0000 (+0100) Subject: gpio: sysfs: fix memory leak in gpiod_export_link X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=0f303db08df0df9bd0966443ad6001e63960af16;p=linux-beck.git gpio: sysfs: fix memory leak in gpiod_export_link Fix memory leak in the gpio sysfs interface due to failure to drop reference to device returned by class_find_device when creating a link. Fixes: a4177ee7f1a8 ("gpiolib: allow exported GPIO nodes to be named using sysfs links") Cc: stable # v2.6.32 Signed-off-by: Johan Hovold Signed-off-by: Linus Walleij --- diff --git a/drivers/gpio/gpiolib-sysfs.c b/drivers/gpio/gpiolib-sysfs.c index f62aa115d79a..4667830f350e 100644 --- a/drivers/gpio/gpiolib-sysfs.c +++ b/drivers/gpio/gpiolib-sysfs.c @@ -648,6 +648,7 @@ int gpiod_export_link(struct device *dev, const char *name, if (tdev != NULL) { status = sysfs_create_link(&dev->kobj, &tdev->kobj, name); + put_device(tdev); } else { status = -ENODEV; }