From: Alexander Shiyan Date: Sat, 15 Feb 2014 10:59:01 +0000 (+0400) Subject: serial: max310x: Fix sparse warnings X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=0fd927f578e96fe56f1acbfe97e6c71e6c3a4b11;p=linux-beck.git serial: max310x: Fix sparse warnings sparse warnings: (new ones prefixed by >>) >> drivers/tty/serial/max310x.c:906:45: sparse: incorrect type in argument 2 (different address spaces) drivers/tty/serial/max310x.c:906:45: expected void const [noderef] *from drivers/tty/serial/max310x.c:906:45: got struct serial_rs485 * >> drivers/tty/serial/max310x.c:938:35: sparse: incorrect type in argument 1 (different address spaces) drivers/tty/serial/max310x.c:938:35: expected void [noderef] *to drivers/tty/serial/max310x.c:938:35: got struct serial_rs485 * Reported-by: kbuild test robot Signed-off-by: Alexander Shiyan Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/tty/serial/max310x.c b/drivers/tty/serial/max310x.c index 5836168414e4..471dbc1e2b58 100644 --- a/drivers/tty/serial/max310x.c +++ b/drivers/tty/serial/max310x.c @@ -882,8 +882,7 @@ static int max310x_ioctl(struct uart_port *port, unsigned int cmd, switch (cmd) { case TIOCSRS485: - if (copy_from_user(&rs485, (struct serial_rs485 *)arg, - sizeof(rs485))) + if (copy_from_user(&rs485, (void __user *)arg, sizeof(rs485))) return -EFAULT; if (rs485.delay_rts_before_send > 0x0f || rs485.delay_rts_after_send > 0x0f) @@ -914,8 +913,7 @@ static int max310x_ioctl(struct uart_port *port, unsigned int cmd, val = max310x_port_read(port, MAX310X_HDPIXDELAY_REG); rs485.delay_rts_before_send = val >> 4; rs485.delay_rts_after_send = val & 0x0f; - if (copy_to_user((struct serial_rs485 *)arg, &rs485, - sizeof(rs485))) + if (copy_to_user((void __user *)arg, &rs485, sizeof(rs485))) return -EFAULT; return 0; default: