From: Rusty Russell Date: Thu, 15 Dec 2011 03:03:56 +0000 (+1030) Subject: i810: fix module_param bool abuse. X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=109782ec8d2e1886f80be90a295361c1a86a51df;p=linux-beck.git i810: fix module_param bool abuse. The driver says "module_param(ddc3, bool, 0);". But it's not a used as a bool, it's used as a count. Make it a bool. Cc: Antonino Daplas Cc: linux-fbdev@vger.kernel.org Signed-off-by: Rusty Russell Signed-off-by: Florian Tobias Schandinat --- diff --git a/drivers/video/i810/i810_main.c b/drivers/video/i810/i810_main.c index 318f6fb895b2..5a4ac3c85331 100644 --- a/drivers/video/i810/i810_main.c +++ b/drivers/video/i810/i810_main.c @@ -147,7 +147,7 @@ static int vyres __devinitdata; static int sync __devinitdata; static int extvga __devinitdata; static int dcolor __devinitdata; -static int ddc3 __devinitdata = 2; +static bool ddc3 __devinitdata; /*------------------------------------------------------------*/ @@ -1776,7 +1776,7 @@ static void __devinit i810_init_defaults(struct i810fb_par *par, if (sync) par->dev_flags |= ALWAYS_SYNC; - par->ddc_num = ddc3; + par->ddc_num = (ddc3 ? 3 : 2); if (bpp < 8) bpp = 8; @@ -1999,7 +1999,7 @@ static int __devinit i810fb_setup(char *options) else if (!strncmp(this_opt, "dcolor", 6)) dcolor = 1; else if (!strncmp(this_opt, "ddc3", 4)) - ddc3 = 3; + ddc3 = true; else mode_option = this_opt; }