From: Borislav Petkov Date: Fri, 1 May 2009 18:29:53 +0000 (+0200) Subject: ide-tape: fix potential fs requests bug X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=10c0b3437c4dc0d14ac254bbe71e54ea5f238d97;p=linux-beck.git ide-tape: fix potential fs requests bug ide-tape had a potential bug for fs requests when preparing the command packet: it was writing the transfer length as a number of fixed blocks. However, the block layer implies 512 byte blocks and ide-tape can have other block sizes so account for that too. ide-floppy does this calculation properly with the block size factor (floppy->bs_factor). Signed-off-by: Borislav Petkov --- diff --git a/drivers/ide/ide-tape.c b/drivers/ide/ide-tape.c index e16604562f28..fc79cf4812f3 100644 --- a/drivers/ide/ide-tape.c +++ b/drivers/ide/ide-tape.c @@ -586,7 +586,7 @@ static void ide_tape_create_rw_cmd(idetape_tape_t *tape, struct ide_atapi_pc *pc, struct request *rq, u8 opcode) { - unsigned int length = blk_rq_sectors(rq); + unsigned int length = blk_rq_sectors(rq) / (tape->blk_size >> 9); ide_init_pc(pc); put_unaligned(cpu_to_be32(length), (unsigned int *) &pc->c[1]);