From: Nicolas Kaiser Date: Mon, 15 Nov 2010 18:40:28 +0000 (+0100) Subject: davinci: aemif: signedness bug in davinci_aemif_setup_timing() X-Git-Tag: v2.6.38-rc1~471^2^2~3^2~10 X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=12cdd3d71954c2cd6dd556eec25dd7d346735831;p=karo-tx-linux.git davinci: aemif: signedness bug in davinci_aemif_setup_timing() aemif_calc_rate() can return a negative error value, so all the variables that get tested for this value need to be signed. The maximum bit width of WSETUP(WSETUP_MAX) appears to be 30 bits (0xf << 26). Using a signed instead of an unsigned integer shouldn't make a difference here. Signed-off-by: Nicolas Kaiser Acked-by: Sekhar Nori Signed-off-by: Kevin Hilman --- diff --git a/arch/arm/mach-davinci/aemif.c b/arch/arm/mach-davinci/aemif.c index 9c3f500fc12f..1ce70a91f2e9 100644 --- a/arch/arm/mach-davinci/aemif.c +++ b/arch/arm/mach-davinci/aemif.c @@ -90,7 +90,7 @@ int davinci_aemif_setup_timing(struct davinci_aemif_timing *t, void __iomem *base, unsigned cs) { unsigned set, val; - unsigned ta, rhold, rstrobe, rsetup, whold, wstrobe, wsetup; + int ta, rhold, rstrobe, rsetup, whold, wstrobe, wsetup; unsigned offset = A1CR_OFFSET + cs * 4; struct clk *aemif_clk; unsigned long clkrate;