From: Sachin Kamat Date: Tue, 4 Mar 2014 05:46:57 +0000 (+0530) Subject: regulator: s2mps11: Use of_get_child_by_name X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=14256f734ecce8dfb8fdce0e138d18f3fadf882e;p=linux-beck.git regulator: s2mps11: Use of_get_child_by_name of_find_node_by_name walks the allnodes list, and can thus walk outside of the parent node. Use of_get_child_by_name instead. Signed-off-by: Sachin Kamat Signed-off-by: Mark Brown --- diff --git a/drivers/regulator/s2mps11.c b/drivers/regulator/s2mps11.c index cdd8d4066121..906d764e98a8 100644 --- a/drivers/regulator/s2mps11.c +++ b/drivers/regulator/s2mps11.c @@ -616,7 +616,7 @@ static int s2mps11_pmic_probe(struct platform_device *pdev) for (i = 0; i < s2mps11->rdev_num; i++) rdata[i].name = regulators[i].name; - reg_np = of_find_node_by_name(iodev->dev->of_node, "regulators"); + reg_np = of_get_child_by_name(iodev->dev->of_node, "regulators"); if (!reg_np) { dev_err(&pdev->dev, "could not find regulators sub-node\n"); ret = -EINVAL;