From: Joerg Roedel <jroedel@suse.de>
Date: Fri, 16 Jun 2017 14:09:57 +0000 (+0200)
Subject: iommu/amd: Check for error states first in iommu_go_to_state()
X-Git-Tag: v4.13-rc1~52^2^7~4
X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=151b09031a76ba6b6b83f94953074d6f10aa30b3;p=karo-tx-linux.git

iommu/amd: Check for error states first in iommu_go_to_state()

Check if we are in an error state already before calling
into state_next().

Signed-off-by: Joerg Roedel <jroedel@suse.de>
---

diff --git a/drivers/iommu/amd_iommu_init.c b/drivers/iommu/amd_iommu_init.c
index df9ec85271f5..a6b81a05a0d1 100644
--- a/drivers/iommu/amd_iommu_init.c
+++ b/drivers/iommu/amd_iommu_init.c
@@ -2467,14 +2467,14 @@ static int __init state_next(void)
 
 static int __init iommu_go_to_state(enum iommu_init_state state)
 {
-	int ret = 0;
+	int ret = -EINVAL;
 
 	while (init_state != state) {
-		ret = state_next();
 		if (init_state == IOMMU_NOT_FOUND         ||
 		    init_state == IOMMU_INIT_ERROR        ||
 		    init_state == IOMMU_CMDLINE_DISABLED)
 			break;
+		ret = state_next();
 	}
 
 	return ret;