From: Jens Axboe Date: Fri, 18 Jun 2010 10:10:18 +0000 (+0200) Subject: virtio_blk: add default case to cmd type switch X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=15fa6e81650a167f82dc0d478f290f1cffa9183d;p=linux-beck.git virtio_blk: add default case to cmd type switch On compilation, gcc correctly detects that we do not handle all types: In function ‘blk_done’: warning: enumeration value ‘REQ_TYPE_FS’ not handled in switch warning: enumeration value ‘REQ_TYPE_SENSE’ not handled in switch warning: enumeration value ‘REQ_TYPE_PM_SUSPEND’ not handled in switch warning: enumeration value ‘REQ_TYPE_PM_RESUME’ not handled in switch warning: enumeration value ‘REQ_TYPE_PM_SHUTDOWN’ not handled in switch warning: enumeration value ‘REQ_TYPE_LINUX_BLOCK’ not handled in switch warning: enumeration value ‘REQ_TYPE_ATA_TASKFILE’ not handled in switch warning: enumeration value ‘REQ_TYPE_ATA_PC’ not handled in switch which is a bit pointless since this is at the end of the request processessing. Add a default case that just breaks out. Signed-off-by: Jens Axboe --- diff --git a/drivers/block/virtio_blk.c b/drivers/block/virtio_blk.c index 774144334ece..b5ebcd33bdb6 100644 --- a/drivers/block/virtio_blk.c +++ b/drivers/block/virtio_blk.c @@ -74,6 +74,8 @@ static void blk_done(struct virtqueue *vq) case REQ_TYPE_SPECIAL: vbr->req->errors = (error != 0); break; + default: + break; } __blk_end_request_all(vbr->req, error);