From: Johan Hovold Date: Wed, 1 Jul 2015 10:37:29 +0000 (+0200) Subject: greybus: operation: drop redundant oom message X-Git-Tag: v4.9-rc1~119^2~378^2~21^2~1418 X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=1635304d6384e258d197ca1bc5f2f6418eae28e2;p=karo-tx-linux.git greybus: operation: drop redundant oom message Drop redundant OOM message, which would already have been logged by the memory subsystem. Also remove a FIXME about possibly sending a pre-allocated response, which is neither possible or desirable. If we ever run out of memory we have bigger problems then getting a response back to firmware. Signed-off-by: Johan Hovold Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/staging/greybus/operation.c b/drivers/staging/greybus/operation.c index b32010ba7bc1..d6e1db87e30a 100644 --- a/drivers/staging/greybus/operation.c +++ b/drivers/staging/greybus/operation.c @@ -673,12 +673,8 @@ static int gb_operation_response_send(struct gb_operation *operation, return 0; if (!operation->response) { - if (!gb_operation_response_alloc(operation, 0)) { - dev_err(&connection->dev, - "error allocating response\n"); - /* XXX Respond with pre-allocated -ENOMEM? */ + if (!gb_operation_response_alloc(operation, 0)) return -ENOMEM; - } } /* Reference will be dropped when message has been sent. */