From: Wei Yongjun <weiyongjun1@huawei.com>
Date: Sat, 17 Sep 2016 01:13:46 +0000 (+0000)
Subject: serial: mxs-auart: Fix missing clk_disable_unprepare() on error in mxs_get_clks()
X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=1664bc40d31403a755fe88307410ed858fe2c6c9;p=linux-beck.git

serial: mxs-auart: Fix missing clk_disable_unprepare() on error in mxs_get_clks()

Commit 5d7519dfc963 ("serial: mxs-auart: Disable clock on error path")
try to disable clock on error path, but still missing the clk_set_rate()
error handling path.

Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Reviewed-by: Fabio Estevam <fabio.estevam@nxp.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---

diff --git a/drivers/tty/serial/mxs-auart.c b/drivers/tty/serial/mxs-auart.c
index ec0ab33efd9d..770454e0dfa3 100644
--- a/drivers/tty/serial/mxs-auart.c
+++ b/drivers/tty/serial/mxs-auart.c
@@ -1534,7 +1534,7 @@ static int mxs_get_clks(struct mxs_auart_port *s,
 	err = clk_set_rate(s->clk, clk_get_rate(s->clk_ahb));
 	if (err) {
 		dev_err(s->dev, "Failed to set rate!\n");
-		return err;
+		goto disable_clk_ahb;
 	}
 
 	err = clk_prepare_enable(s->clk);