From: Stanimir Varbanov <stanimir.varbanov@linaro.org>
Date: Thu, 15 Jun 2017 16:31:56 +0000 (-0300)
Subject: [media] media: venus: vdec: fix compile error in vdec_close
X-Git-Tag: v4.13-rc1~141^2~84
X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=17571ed6e238ef1353595a87b40414d12b0e0275;p=karo-tx-linux.git

[media] media: venus: vdec: fix compile error in vdec_close

This fixes the following compile error ocured when building
with gcc7:

drivers/media/platform/qcom/venus/vdec.c:1022
vdec_close() error: dereferencing freed memory 'inst'

by moving kfree as a last call.

Signed-off-by: Stanimir Varbanov <stanimir.varbanov@linaro.org>
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
---

diff --git a/drivers/media/platform/qcom/venus/vdec.c b/drivers/media/platform/qcom/venus/vdec.c
index 96e7e7e71e5f..594315b55b1f 100644
--- a/drivers/media/platform/qcom/venus/vdec.c
+++ b/drivers/media/platform/qcom/venus/vdec.c
@@ -1017,9 +1017,10 @@ static int vdec_close(struct file *file)
 	mutex_destroy(&inst->lock);
 	v4l2_fh_del(&inst->fh);
 	v4l2_fh_exit(&inst->fh);
-	kfree(inst);
 
 	pm_runtime_put_sync(inst->core->dev_dec);
+
+	kfree(inst);
 	return 0;
 }