From: Markus Elfring <elfring@users.sourceforge.net>
Date: Mon, 23 Nov 2015 19:16:45 +0000 (+0100)
Subject: rbd: delete an unnecessary check before rbd_dev_destroy()
X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=1761b22966e61494f51be76bc3b10e9c1ff809ad;p=linux-beck.git

rbd: delete an unnecessary check before rbd_dev_destroy()

The rbd_dev_destroy() function tests whether its argument is NULL
and then returns immediately. Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
---

diff --git a/drivers/block/rbd.c b/drivers/block/rbd.c
index 81ea69fee7ca..4a876785b68c 100644
--- a/drivers/block/rbd.c
+++ b/drivers/block/rbd.c
@@ -5185,8 +5185,7 @@ static int rbd_dev_probe_parent(struct rbd_device *rbd_dev, int depth)
 
 out_err:
 	rbd_dev_unparent(rbd_dev);
-	if (parent)
-		rbd_dev_destroy(parent);
+	rbd_dev_destroy(parent);
 	return ret;
 }