From: Alex Elder Date: Tue, 25 Nov 2014 19:06:44 +0000 (-0600) Subject: greybus: fix some error codes X-Git-Tag: v4.9-rc1~119^2~378^2~21^2~1815 X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=1a365154c24a3fd48b96ad25cb67a483124d56ad;p=karo-tx-linux.git greybus: fix some error codes Change the message result values used in two cases. First, use -EMSGSIZE rather than -E2BIG to represent a message that is larger than the buffer intended to hold it. That is the proper code for this situation. Second, use -ECANCELED rather than -EINTR for an operation that has been canceled. The definition of that error is literally "Operation Canceled" so it seems like the right thing to do. Signed-off-by: Alex Elder Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/staging/greybus/operation.c b/drivers/staging/greybus/operation.c index 82fd7e98074c..5e5c0977f35d 100644 --- a/drivers/staging/greybus/operation.c +++ b/drivers/staging/greybus/operation.c @@ -324,7 +324,7 @@ int gb_operation_status_map(u8 status) case GB_OP_PROTOCOL_BAD: return -EPROTONOSUPPORT; case GB_OP_OVERFLOW: - return -E2BIG; + return -EMSGSIZE; case GB_OP_TIMEOUT: return -ETIMEDOUT; default: @@ -510,7 +510,7 @@ int gb_operation_request_send(struct gb_operation *operation, /* Cancel the operation if interrupted */ ret = wait_for_completion_interruptible(&operation->completion); if (ret < 0) - gb_operation_cancel(operation, -EINTR); + gb_operation_cancel(operation, -ECANCELED); return gb_operation_result(operation); } @@ -605,7 +605,7 @@ static void gb_connection_recv_response(struct gb_connection *connection, result = gb_operation_status_map(header->result); } else { gb_connection_err(connection, "recv buffer too small"); - result = -E2BIG; + result = -EMSGSIZE; } /* We must ignore the payload if a bad status is returned */