From: Amit Nagal <helloin.amit@gmail.com>
Date: Wed, 7 Sep 2011 11:48:47 +0000 (+0200)
Subject: HID: hidraw: free list for all error in hidraw_open
X-Git-Tag: next-20110915~69^2^2
X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=1a8962317f494ad858971fc08ba035eff658a5c9;p=karo-tx-linux.git

HID: hidraw: free list for all error in hidraw_open

In function hidraw_open struct hidraw_list *list should be freed for
all error conditions.

Signed-off-by: Amit Nagal <helloin.amit@gmail.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
---

diff --git a/drivers/hid/hidraw.c b/drivers/hid/hidraw.c
index c79578b5a788..c841a8e77339 100644
--- a/drivers/hid/hidraw.c
+++ b/drivers/hid/hidraw.c
@@ -259,7 +259,6 @@ static int hidraw_open(struct inode *inode, struct file *file)
 
 	mutex_lock(&minors_lock);
 	if (!hidraw_table[minor]) {
-		kfree(list);
 		err = -ENODEV;
 		goto out_unlock;
 	}
@@ -285,6 +284,8 @@ static int hidraw_open(struct inode *inode, struct file *file)
 out_unlock:
 	mutex_unlock(&minors_lock);
 out:
+	if (err < 0)
+		kfree(list);
 	return err;
 
 }