From: Charles Keepax Date: Wed, 8 Mar 2017 16:42:47 +0000 (+0000) Subject: ASoC: cs35l35: Add missing return in probe X-Git-Tag: v4.12-rc1~115^2^2~10^2~15 X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=1bb06ada038548b4e2449159e80badf106bb779f;p=karo-tx-linux.git ASoC: cs35l35: Add missing return in probe A return statement is missing just before the error paths at the end of probe. This causes us to fall straight into the error path and disable the supplies and re-enable reset, as these are only controlled during probe this causes the part to no longer function. Signed-off-by: Charles Keepax Acked-by: Brian Austin Signed-off-by: Mark Brown --- diff --git a/sound/soc/codecs/cs35l35.c b/sound/soc/codecs/cs35l35.c index 260ed42c71e9..48b45dc904ea 100644 --- a/sound/soc/codecs/cs35l35.c +++ b/sound/soc/codecs/cs35l35.c @@ -1509,6 +1509,8 @@ static int cs35l35_i2c_probe(struct i2c_client *i2c_client, goto err; } + return 0; + err: regulator_bulk_disable(cs35l35->num_supplies, cs35l35->supplies);