From: Marek Vasut Date: Wed, 4 Jul 2012 23:30:10 +0000 (+0200) Subject: ACER: Fix Smatch double-free issue X-Git-Tag: next-20120731~83^2~4 X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=1bfaf1d5bcfb2ae0b7b90c5aed86909ee4f3f099;p=karo-tx-linux.git ACER: Fix Smatch double-free issue The patch 6ae3a0876185: "ACER: Add support for accelerometer sensor" from Jun 1, 2012, leads to the following Smatch warning: drivers/platform/x86/acer-wmi.c:1886 acer_wmi_accel_destroy() error: don't call input_free_device() after input_unregister_device() drivers/platform/x86/acer-wmi.c 1883 static void acer_wmi_accel_destroy(void) 1884 { 1885 input_unregister_device(acer_wmi_accel_dev); 1886 input_free_device(acer_wmi_accel_dev); 1887 } Reported-by: Dan Carpenter Signed-off-by: Marek Vasut Cc: Matthew Garrett Cc: Fengguang Wu Cc: joeyli Cc: Dan Carpenter Signed-off-by: Matthew Garrett --- diff --git a/drivers/platform/x86/acer-wmi.c b/drivers/platform/x86/acer-wmi.c index cdee5ecf4bf6..3782e1cd3697 100644 --- a/drivers/platform/x86/acer-wmi.c +++ b/drivers/platform/x86/acer-wmi.c @@ -1883,7 +1883,6 @@ err_free_dev: static void acer_wmi_accel_destroy(void) { input_unregister_device(acer_wmi_accel_dev); - input_free_device(acer_wmi_accel_dev); } static int __init acer_wmi_input_setup(void)