From: H Hartley Sweeten Date: Wed, 12 Aug 2015 20:25:50 +0000 (-0700) Subject: staging: comedi: hwdrv_apci3501: remove "magic" numbers in apci3501_read_insn_timer() X-Git-Tag: v4.3-rc1~158^2~87 X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=1c38d03ea9b7b92f958ce6b3c2337413227bcb6b;p=karo-tx-linux.git staging: comedi: hwdrv_apci3501: remove "magic" numbers in apci3501_read_insn_timer() Use register bit defines from addi_tcw.h to remove the "magic" numbers. Signed-off-by: H Hartley Sweeten Reviewed-by: Ian Abbott Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/staging/comedi/drivers/addi-data/hwdrv_apci3501.c b/drivers/staging/comedi/drivers/addi-data/hwdrv_apci3501.c index d971f7a0926f..375707497896 100644 --- a/drivers/staging/comedi/drivers/addi-data/hwdrv_apci3501.c +++ b/drivers/staging/comedi/drivers/addi-data/hwdrv_apci3501.c @@ -133,7 +133,8 @@ static int apci3501_read_insn_timer(struct comedi_device *dev, devpriv->timer_mode != ADDIDATA_WATCHDOG) return -EINVAL; - data[0] = inl(devpriv->tcw + ADDI_TCW_STATUS_REG) & 0x1; + data[0] = inl(devpriv->tcw + ADDI_TCW_STATUS_REG) & + ADDI_TCW_STATUS_OVERFLOW; data[1] = inl(devpriv->tcw + ADDI_TCW_VAL_REG); return insn->n;