From: John Törnblom Date: Mon, 17 Dec 2012 11:53:54 +0000 (-0300) Subject: [media] bttv: avoid flooding the kernel log when i2c debugging is disabled X-Git-Tag: next-20130218~80^2~6^2~31 X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=1ca6ae8de8a563f69eebe114d023855b4f0bcb1b;p=karo-tx-linux.git [media] bttv: avoid flooding the kernel log when i2c debugging is disabled When the bttv driver is running without i2c_debug being set, the kernel log is being flooded with the string ">". This string is really a part of a debug message that is logged using several substrings protected by a conditional check. This patch adds the same conditional check to the leaked substring. Signed-off-by: John Törnblom Signed-off-by: Mauro Carvalho Chehab --- diff --git a/drivers/media/pci/bt8xx/bttv-i2c.c b/drivers/media/pci/bt8xx/bttv-i2c.c index 580c8e682392..da400dbe4a10 100644 --- a/drivers/media/pci/bt8xx/bttv-i2c.c +++ b/drivers/media/pci/bt8xx/bttv-i2c.c @@ -173,7 +173,7 @@ bttv_i2c_sendbytes(struct bttv *btv, const struct i2c_msg *msg, int last) if (i2c_debug) pr_cont(" %02x", msg->buf[cnt]); } - if (!(xmit & BT878_I2C_NOSTOP)) + if (i2c_debug && !(xmit & BT878_I2C_NOSTOP)) pr_cont(">\n"); return msg->len;