From: Jim Cromie <jim.cromie@gmail.com>
Date: Thu, 3 May 2012 17:57:37 +0000 (-0600)
Subject: params.c: fix Smack complaint about parse_args
X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=1ef9eaf2bf8901e92bb931875a5621692c8a0b84;p=linux-beck.git

params.c: fix Smack complaint about parse_args

In commit 9fb48c744: "params: add 3rd arg to option handler callback
signature", the if-guard added to the pr_debug was overzealous; no
callers pass NULL, and existing code above and below the guard assumes
as much.  Change the if-guard to match, and silence the Smack
complaint.

CC: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Jim Cromie <jim.cromie@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---

diff --git a/kernel/params.c b/kernel/params.c
index b60e2c74b961..be78c904b564 100644
--- a/kernel/params.c
+++ b/kernel/params.c
@@ -190,7 +190,7 @@ int parse_args(const char *doing,
 	/* Chew leading spaces */
 	args = skip_spaces(args);
 
-	if (args && *args)
+	if (*args)
 		pr_debug("doing %s, parsing ARGS: '%s'\n", doing, args);
 
 	while (*args) {