From: Daeseok Youn Date: Wed, 15 Mar 2017 05:55:06 +0000 (+0900) Subject: staging: atomisp: fix unsigned int comparison with less than zero X-Git-Tag: v4.12-rc1~84^2~501 X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=1fe996642108d44c3e649640850e709724f9f311;p=karo-tx-linux.git staging: atomisp: fix unsigned int comparison with less than zero Fix warnings from the smatch tool atomisp_cmd.c:2649 atomisp_set_array_res() warn: unsigned 'config->width' is never less than zero. atomisp_cmd.c:2650 atomisp_set_array_res() warn: unsigned 'config->height' is never less than zero. Signed-off-by: Daeseok Youn Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c b/drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c index 1ee99d0e43ee..9c3ba11c408f 100644 --- a/drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c +++ b/drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c @@ -2646,8 +2646,7 @@ int atomisp_set_array_res(struct atomisp_sub_device *asd, struct atomisp_resolution *config) { dev_dbg(asd->isp->dev, ">%s start\n", __func__); - if (config == NULL || config->width < 0 - || config->height < 0) { + if (!config) { dev_err(asd->isp->dev, "Set sensor array size is not valid\n"); return -EINVAL; }