From: Stefan Richter <stefanr@s5r6.in-berlin.de>
Date: Tue, 10 Mar 2009 20:01:08 +0000 (+0100)
Subject: firewire: cdev: fix race of ioctl_send_request with bus reset
X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=207fbefb18de9bc6f871e4008da29879c90cb67e;p=linux-beck.git

firewire: cdev: fix race of ioctl_send_request with bus reset

The bus reset handler concurrently frees client->device->node.  Use
device->node_id instead.  This is equivalent to device->node->node_id
while device->generation is current.

Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
---

diff --git a/drivers/firewire/fw-cdev.c b/drivers/firewire/fw-cdev.c
index 160cb27e120c..c54e019c9586 100644
--- a/drivers/firewire/fw-cdev.c
+++ b/drivers/firewire/fw-cdev.c
@@ -585,7 +585,7 @@ static int ioctl_send_request(struct client *client, void *buffer)
 		return -EINVAL;
 	}
 
-	return init_request(client, request, client->device->node->node_id,
+	return init_request(client, request, client->device->node_id,
 			    client->device->max_speed);
 }