From: Bud Brown Date: Wed, 23 Mar 2011 19:47:11 +0000 (+0100) Subject: cciss: fix lost command issue X-Git-Tag: v2.6.34.11~189 X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=209b65108ec6a83941b8089b75c2699af0339105;p=karo-tx-linux.git cciss: fix lost command issue commit 1ddd5049545e0aa1a0ed19bca4d9c9c3ce1ac8a2 upstream. Under certain workloads a command may seem to get lost. IOW, the Smart Array thinks all commands have been completed but we still have commands in our completion queue. This may lead to system instability, filesystems going read-only, or even panics depending on the affected filesystem. We add an extra read to force the write to complete. Testing shows this extra read avoids the problem. Signed-off-by: Mike Miller Signed-off-by: Jens Axboe Signed-off-by: Paul Gortmaker --- diff --git a/drivers/block/cciss.h b/drivers/block/cciss.h index c5d411174db0..37a2d4fb01d8 100644 --- a/drivers/block/cciss.h +++ b/drivers/block/cciss.h @@ -173,6 +173,7 @@ static void SA5_submit_command( ctlr_info_t *h, CommandList_struct *c) printk("Sending %x - down to controller\n", c->busaddr ); #endif /* CCISS_DEBUG */ writel(c->busaddr, h->vaddr + SA5_REQUEST_PORT_OFFSET); + readl(h->vaddr + SA5_REQUEST_PORT_OFFSET); h->commands_outstanding++; if ( h->commands_outstanding > h->max_outstanding) h->max_outstanding = h->commands_outstanding;