From: Axel Lin Date: Wed, 13 Jul 2011 07:03:36 +0000 (-0700) Subject: Input: cy8ctmg110_ts - fix checking return value of i2c_master_send X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=21184c4efbba7b7959c7868cf2b99f43f29fc199;p=linux-beck.git Input: cy8ctmg110_ts - fix checking return value of i2c_master_send i2c_master_send returns negative errno, or else the number of bytes written. Signed-off-by: Axel Lin Signed-off-by: Dmitry Torokhov --- diff --git a/drivers/input/touchscreen/cy8ctmg110_ts.c b/drivers/input/touchscreen/cy8ctmg110_ts.c index a93c5c26ab3f..b3fdd1361c36 100644 --- a/drivers/input/touchscreen/cy8ctmg110_ts.c +++ b/drivers/input/touchscreen/cy8ctmg110_ts.c @@ -84,9 +84,9 @@ static int cy8ctmg110_write_regs(struct cy8ctmg110 *tsc, unsigned char reg, memcpy(i2c_data + 1, value, len); ret = i2c_master_send(client, i2c_data, len + 1); - if (ret != 1) { + if (ret != len + 1) { dev_err(&client->dev, "i2c write data cmd failed\n"); - return ret ? ret : -EIO; + return ret < 0 ? ret : -EIO; } return 0;