From: Felipe Balbi <balbi@ti.com>
Date: Tue, 29 May 2012 11:38:32 +0000 (+0300)
Subject: usb: gadget: omap_udc: kfree(NULL) is safe
X-Git-Tag: next-20120724~22^2~53^2~28^2~32
X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=23673d7d26d81bd17cde3ed74c57b3f39585325f;p=karo-tx-linux.git

usb: gadget: omap_udc: kfree(NULL) is safe

we don't need to check for _req because
kfree(NULL) is safe. Also, if someone
actually passes a NULL pointer to be freed
by usb_ep_free_request(), he deserves any
issue he faces.

Signed-off-by: Felipe Balbi <balbi@ti.com>
---

diff --git a/drivers/usb/gadget/omap_udc.c b/drivers/usb/gadget/omap_udc.c
index f13bcdc75676..50e8490867ed 100644
--- a/drivers/usb/gadget/omap_udc.c
+++ b/drivers/usb/gadget/omap_udc.c
@@ -282,8 +282,7 @@ omap_free_request(struct usb_ep *ep, struct usb_request *_req)
 {
 	struct omap_req	*req = container_of(_req, struct omap_req, req);
 
-	if (_req)
-		kfree(req);
+	kfree(req);
 }
 
 /*-------------------------------------------------------------------------*/