From: Sandhya Bankar Date: Sun, 18 Sep 2016 17:32:33 +0000 (+0530) Subject: Staging: octeon: Add missing of_node_put after calling of_parse_phandle. X-Git-Tag: v4.9-rc1~119^2~311 X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=24586a35d3edfed3217fec3597861d52eb6d5814;p=karo-tx-linux.git Staging: octeon: Add missing of_node_put after calling of_parse_phandle. of_node_put needs to be called when the device node which is got from of_parse_phandle is no longer used. This patch is found by below coccinelle script: @@ expression e,e1,e2; @@ *e = of_parse_phandle(...) ... when != of_node_put(e) when != true e == NULL when != e2 = e e = e1 Signed-off-by: Sandhya Bankar Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/staging/octeon/ethernet-mdio.c b/drivers/staging/octeon/ethernet-mdio.c index 1fde9c824948..691e4a51ace4 100644 --- a/drivers/staging/octeon/ethernet-mdio.c +++ b/drivers/staging/octeon/ethernet-mdio.c @@ -168,6 +168,7 @@ int cvm_oct_phy_setup_device(struct net_device *dev) phydev = of_phy_connect(dev, phy_node, cvm_oct_adjust_link, 0, PHY_INTERFACE_MODE_GMII); + of_node_put(phy_node); if (!phydev) return -ENODEV;