From: Michael Ellerman Date: Fri, 23 Jun 2006 08:20:10 +0000 (+1000) Subject: [POWERPC] Make rtas_call() safe if RTAS hasn't been initialised X-Git-Tag: v2.6.18-rc1~358^2~29 X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=24da3dd53430ec07ce9110b1eaaad080c3c7ecf6;p=karo-tx-linux.git [POWERPC] Make rtas_call() safe if RTAS hasn't been initialised Currently it's unsafe to call rtas_call() prior to rtas_initialize(). This is because the rtas.entry value hasn't been setup and so we don't know where to enter, but we just try anyway. We can't do anything intelligent without rtas.entry, so if it's not set, just return. Code that calls rtas_call() early needs to be aware that the call might fail. Signed-off-by: Michael Ellerman Signed-off-by: Paul Mackerras --- diff --git a/arch/powerpc/kernel/rtas.c b/arch/powerpc/kernel/rtas.c index 17dc79198515..0f14c2e63a67 100644 --- a/arch/powerpc/kernel/rtas.c +++ b/arch/powerpc/kernel/rtas.c @@ -328,7 +328,7 @@ int rtas_call(int token, int nargs, int nret, int *outputs, ...) char *buff_copy = NULL; int ret; - if (token == RTAS_UNKNOWN_SERVICE) + if (!rtas.entry || token == RTAS_UNKNOWN_SERVICE) return -1; /* Gotta do something different here, use global lock for now... */