From: Uwe Kleine-König Date: Mon, 5 Mar 2012 19:08:36 +0000 (-0800) Subject: ARM: OMAP4: board-4430sdp: don't initialize value that is never used X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=2534b4a429aa31037c29079c25506c43e71f8f9f;p=mv-sheeva.git ARM: OMAP4: board-4430sdp: don't initialize value that is never used sdp4430_spi_board_info.irq was initialized to ETH_KS8851_IRQ and in omap_4430sdp_init() overwritten with gpio_to_irq(ETH_KS8851_IRQ) before sdp4430_spi_board_info was registered. This is a bit confusing, so better don't initialize .irq and document that it is set later. Signed-off-by: Uwe Kleine-König Signed-off-by: Tony Lindgren --- diff --git a/arch/arm/mach-omap2/board-4430sdp.c b/arch/arm/mach-omap2/board-4430sdp.c index 4e9071589bf..766f7e47771 100644 --- a/arch/arm/mach-omap2/board-4430sdp.c +++ b/arch/arm/mach-omap2/board-4430sdp.c @@ -322,7 +322,10 @@ static struct spi_board_info sdp4430_spi_board_info[] __initdata = { .bus_num = 1, .chip_select = 0, .max_speed_hz = 24000000, - .irq = ETH_KS8851_IRQ, + /* + * .irq is set to gpio_to_irq(ETH_KS8851_IRQ) + * in omap_4430sdp_init + */ }, };