From: Axel Lin Date: Sat, 2 Aug 2014 05:36:38 +0000 (+0800) Subject: hwmon: (gpio-fan) Prevent overflow problem when writing large limits X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=2565fb05d1e9fc0831f7b1c083bcfcb1cba1f020;p=linux-beck.git hwmon: (gpio-fan) Prevent overflow problem when writing large limits On platforms with sizeof(int) < sizeof(unsigned long), writing a rpm value larger than MAXINT will result in unpredictable limit values written to the chip. Avoid auto-conversion from unsigned long to int to fix the problem. Signed-off-by: Axel Lin Cc: stable@vger.kernel.org Signed-off-by: Guenter Roeck --- diff --git a/drivers/hwmon/gpio-fan.c b/drivers/hwmon/gpio-fan.c index a43e5b004eb8..4efa1734bdad 100644 --- a/drivers/hwmon/gpio-fan.c +++ b/drivers/hwmon/gpio-fan.c @@ -173,7 +173,7 @@ static int get_fan_speed_index(struct gpio_fan_data *fan_data) return -ENODEV; } -static int rpm_to_speed_index(struct gpio_fan_data *fan_data, int rpm) +static int rpm_to_speed_index(struct gpio_fan_data *fan_data, unsigned long rpm) { struct gpio_fan_speed *speed = fan_data->speed; int i;