From: Larry Finger Date: Sat, 8 Apr 2017 16:07:26 +0000 (-0500) Subject: staging: rtl8723bs: Fix dereference before check warning in os_dep/recv_linux.c X-Git-Tag: v4.12-rc1~84^2~219 X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=2679a3fbef60884260542587e73565979f3d4fd1;p=karo-tx-linux.git staging: rtl8723bs: Fix dereference before check warning in os_dep/recv_linux.c Smatch lists the following warning: CHECK drivers/staging/rtl8723bs/os_dep/recv_linux.c drivers/staging/rtl8723bs/os_dep/recv_linux.c:353 rtw_recv_indicatepkt() warn: variable dereferenced before check 'precv_frame' (see line 312) This warning is fixed by removing the test at line 353. Signed-off-by: Larry Finger Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/staging/rtl8723bs/os_dep/recv_linux.c b/drivers/staging/rtl8723bs/os_dep/recv_linux.c index c677a5216b54..e731ab4e2bd7 100644 --- a/drivers/staging/rtl8723bs/os_dep/recv_linux.c +++ b/drivers/staging/rtl8723bs/os_dep/recv_linux.c @@ -350,8 +350,7 @@ int rtw_recv_indicatepkt(struct adapter *padapter, union recv_frame *precv_frame _recv_indicatepkt_drop: /* enqueue back to free_recv_queue */ - if (precv_frame) - rtw_free_recvframe(precv_frame, pfree_recv_queue); + rtw_free_recvframe(precv_frame, pfree_recv_queue); DBG_COUNTER(padapter->rx_logs.os_indicate_err); return _FAIL;