From: Kent Overstreet Date: Thu, 13 Mar 2014 20:44:21 +0000 (-0700) Subject: bcache: Fix a journalling reclaim after recovery bug X-Git-Tag: v3.15-rc1~134^2^2~18 X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=27201cfdaa2aeb571191494c1bae6863ffb04108;p=karo-tx-linux.git bcache: Fix a journalling reclaim after recovery bug On recovery we weren't correctly keeping track of what journal buckets had open journal entries, thus it was possible for them to be overwritten until we'd written all new journal entries. Signed-off-by: Kent Overstreet --- diff --git a/drivers/md/bcache/journal.c b/drivers/md/bcache/journal.c index 97e6a92da999..4152a9119896 100644 --- a/drivers/md/bcache/journal.c +++ b/drivers/md/bcache/journal.c @@ -237,8 +237,14 @@ bsearch: for (i = 0; i < ca->sb.njournal_buckets; i++) if (ja->seq[i] > seq) { seq = ja->seq[i]; - ja->cur_idx = ja->discard_idx = - ja->last_idx = i; + /* + * When journal_reclaim() goes to allocate for + * the first time, it'll use the bucket after + * ja->cur_idx + */ + ja->cur_idx = i; + ja->last_idx = ja->discard_idx = (i + 1) % + ca->sb.njournal_buckets; } }