From: Dan Carpenter Date: Thu, 23 Jan 2014 08:26:37 +0000 (+0300) Subject: tulip: cleanup by using ARRAY_SIZE() X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=28f39ef6d802d2a5840582efecbf3c729b290e64;p=linux-beck.git tulip: cleanup by using ARRAY_SIZE() In this situation then ARRAY_SIZE() and sizeof() are the same, but we're really dealing with array indexes and not byte offsets so ARRAY_SIZE() is cleaner. Signed-off-by: Dan Carpenter Acked-by: Grant Grundler Signed-off-by: David S. Miller --- diff --git a/drivers/net/ethernet/dec/tulip/media.c b/drivers/net/ethernet/dec/tulip/media.c index 0d0ba725341a..dcf21a36a9cf 100644 --- a/drivers/net/ethernet/dec/tulip/media.c +++ b/drivers/net/ethernet/dec/tulip/media.c @@ -457,7 +457,7 @@ void tulip_find_mii(struct net_device *dev, int board_idx) /* Find the connected MII xcvrs. Doing this in open() would allow detecting external xcvrs later, but takes much time. */ - for (phyn = 1; phyn <= 32 && phy_idx < sizeof (tp->phys); phyn++) { + for (phyn = 1; phyn <= 32 && phy_idx < ARRAY_SIZE(tp->phys); phyn++) { int phy = phyn & 0x1f; int mii_status = tulip_mdio_read (dev, phy, MII_BMSR); if ((mii_status & 0x8301) == 0x8001 ||