From: Roland Dreier Date: Tue, 14 Feb 2012 00:18:16 +0000 (-0800) Subject: target: Don't set WBUS16 or SYNC bits in INQUIRY response X-Git-Tag: v3.0.27~54 X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=2a540015f107ec0b073725ab7575bd7990e094d9;p=karo-tx-linux.git target: Don't set WBUS16 or SYNC bits in INQUIRY response commit effc6cc8828257c32c37635e737f14fd6e19ecd7 upstream. SPC-4 says about the WBUS16 and SYNC bits: The meanings of these fields are specific to SPI-5 (see 6.4.3). For SCSI transport protocols other than the SCSI Parallel Interface, these fields are reserved. We don't have a SPI fabric module, so we should never set these bits. (The comment was misleading, since it only mentioned Sync but the actual code set WBUS16 too). Signed-off-by: Roland Dreier Signed-off-by: Nicholas Bellinger Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/target/target_core_cdb.c b/drivers/target/target_core_cdb.c index f044d45fc58c..05584010e70e 100644 --- a/drivers/target/target_core_cdb.c +++ b/drivers/target/target_core_cdb.c @@ -106,7 +106,7 @@ target_emulate_inquiry_std(struct se_cmd *cmd) return 0; } - buf[7] = 0x32; /* Sync=1 and CmdQue=1 */ + buf[7] = 0x2; /* CmdQue=1 */ /* * Do not include vendor, product, reversion info in INQUIRY