From: Raphael Assenat Date: Sun, 13 Jan 2008 22:55:18 +0000 (+0000) Subject: leds: Fix led-gpio active_low default brightness X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=2b7f1b8c8f4a8991dfeefc31844e15c642b6de2a;p=linux-beck.git leds: Fix led-gpio active_low default brightness When gpio_direction_output() is called, led_dat->active_low is used as default value. This means that the led will always be off by default. cdev.brightness should really have been set to LED_OFF unconditionally to reflect this behavior. Signed-off-by: Raphael Assenat Signed-off-by: Richard Purdie --- diff --git a/drivers/leds/leds-gpio.c b/drivers/leds/leds-gpio.c index 99bc50059d35..6c0a9c4761ee 100644 --- a/drivers/leds/leds-gpio.c +++ b/drivers/leds/leds-gpio.c @@ -85,7 +85,7 @@ static int gpio_led_probe(struct platform_device *pdev) led_dat->can_sleep = gpio_cansleep(cur_led->gpio); led_dat->active_low = cur_led->active_low; led_dat->cdev.brightness_set = gpio_led_set; - led_dat->cdev.brightness = cur_led->active_low ? LED_FULL : LED_OFF; + led_dat->cdev.brightness = LED_OFF; ret = gpio_request(led_dat->gpio, led_dat->cdev.name); if (ret < 0)