From: Krzysztof Opasiak <k.opasiak@samsung.com>
Date: Wed, 27 Apr 2016 18:00:26 +0000 (+0200)
Subject: usb: usbip: vudc: Fix WARN_ON() usage pattern
X-Git-Tag: v4.7-rc1~93^2~35
X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=2bdf6ea51ce8dcd98f4f394d7203dbace01f5cbc;p=karo-tx-linux.git

usb: usbip: vudc: Fix WARN_ON() usage pattern

Fix WARN_ON() macro usage as suggested by Felipe.
Instead of using:
if (cond) {
   WARN_ON(1);
   do_stuff();
}

Use a better pattern with WARN_ON() placed in if condition:

if (WARN_ON(cond))
   do_stuff();

Signed-off-by: Krzysztof Opasiak <k.opasiak@samsung.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---

diff --git a/drivers/usb/usbip/vudc_dev.c b/drivers/usb/usbip/vudc_dev.c
index 43047f4fbca2..0523f2970835 100644
--- a/drivers/usb/usbip/vudc_dev.c
+++ b/drivers/usb/usbip/vudc_dev.c
@@ -312,10 +312,9 @@ static void vep_free_request(struct usb_ep *_ep, struct usb_request *_req)
 {
 	struct vrequest *req;
 
-	if (!_ep || !_req) {
-		WARN_ON(1);
+	if (WARN_ON(!_ep || !_req))
 		return;
-	}
+
 	req = to_vrequest(_req);
 	kfree(req);
 }