From: Andreas Herrmann Date: Sun, 25 Mar 2012 23:42:13 +0000 (+1100) Subject: hwmon: (fam15h_power) Correct sign extension of running_avg_capture X-Git-Tag: next-20120402~45^2~12 X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=2cf324fa7729d22c8ef64ace113caf6f045f5ae1;p=karo-tx-linux.git hwmon: (fam15h_power) Correct sign extension of running_avg_capture Wrong bit was used for sign extension which caused wrong end results. Thanks to Andre for spotting this bug. Reported-by: Andre Przywara Signed-off-by: Andreas Herrmann Acked-by: Guenter Roeck Signed-off-by: Jean Delvare Cc: stable@vger.kernel.org --- diff --git a/drivers/hwmon/fam15h_power.c b/drivers/hwmon/fam15h_power.c index 523f8fb9e7d9..930370de5201 100644 --- a/drivers/hwmon/fam15h_power.c +++ b/drivers/hwmon/fam15h_power.c @@ -60,7 +60,7 @@ static ssize_t show_power(struct device *dev, pci_bus_read_config_dword(f4->bus, PCI_DEVFN(PCI_SLOT(f4->devfn), 5), REG_TDP_RUNNING_AVERAGE, &val); running_avg_capture = (val >> 4) & 0x3fffff; - running_avg_capture = sign_extend32(running_avg_capture, 22); + running_avg_capture = sign_extend32(running_avg_capture, 21); running_avg_range = val & 0xf; pci_bus_read_config_dword(f4->bus, PCI_DEVFN(PCI_SLOT(f4->devfn), 5),