From: Laurent Pinchart Date: Wed, 1 Jan 2014 17:40:35 +0000 (-0300) Subject: [media] v4l: mt9v032: Consider control initialization errors as fatal X-Git-Tag: v4.1-rc1~59^2~1^2~137 X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=2d01209fd2d96cb9cd07b5c353efc47b525d71dc;p=karo-tx-linux.git [media] v4l: mt9v032: Consider control initialization errors as fatal The device requires control to be properly operated, they're not optional. Signed-off-by: Laurent Pinchart Signed-off-by: Mauro Carvalho Chehab --- diff --git a/drivers/media/i2c/mt9v032.c b/drivers/media/i2c/mt9v032.c index 3793d317772b..6d64e23b1f94 100644 --- a/drivers/media/i2c/mt9v032.c +++ b/drivers/media/i2c/mt9v032.c @@ -961,9 +961,12 @@ static int mt9v032_probe(struct i2c_client *client, mt9v032->subdev.ctrl_handler = &mt9v032->ctrls; - if (mt9v032->ctrls.error) - printk(KERN_INFO "%s: control initialization error %d\n", - __func__, mt9v032->ctrls.error); + if (mt9v032->ctrls.error) { + dev_err(&client->dev, "control initialization error %d\n", + mt9v032->ctrls.error); + ret = mt9v032->ctrls.error; + goto err; + } mt9v032->crop.left = MT9V032_COLUMN_START_DEF; mt9v032->crop.top = MT9V032_ROW_START_DEF;