From: Andi Kleen Date: Thu, 3 May 2012 05:44:08 +0000 (+1000) Subject: drivers/scsi/aha152x.c: remove broken usage of spin_is_locked() X-Git-Tag: next-20120503~2^2~145 X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=2e67fea7eb66a16dbd2da056729c3fbde46e7fbf;p=karo-tx-linux.git drivers/scsi/aha152x.c: remove broken usage of spin_is_locked() Remove racy usage of spin_is_locked. The author seems to have been unclear on the concept of locking. This is debug code normally not enabled, but I caught it on a tree sweep. Signed-off-by: Andi Kleen Cc: James Bottomley Signed-off-by: Andrew Morton --- diff --git a/drivers/scsi/aha152x.c b/drivers/scsi/aha152x.c index 19a36945e6fd..58bec224ebee 100644 --- a/drivers/scsi/aha152x.c +++ b/drivers/scsi/aha152x.c @@ -287,9 +287,6 @@ static LIST_HEAD(aha152x_host_list); #define DO_LOCK(flags) \ do { \ - if(spin_is_locked(&QLOCK)) { \ - DPRINTK(debug_intr, DEBUG_LEAD "(%s:%d) already locked at %s:%d\n", CMDINFO(CURRENT_SC), __func__, __LINE__, QLOCKER, QLOCKERL); \ - } \ DPRINTK(debug_locking, DEBUG_LEAD "(%s:%d) locking\n", CMDINFO(CURRENT_SC), __func__, __LINE__); \ spin_lock_irqsave(&QLOCK,flags); \ DPRINTK(debug_locking, DEBUG_LEAD "(%s:%d) locked\n", CMDINFO(CURRENT_SC), __func__, __LINE__); \