From: Lars Ellenberg Date: Tue, 11 Feb 2014 07:56:53 +0000 (+0100) Subject: drbd: explicitly submit meta data requests with REQ_NOIDLE X-Git-Tag: v3.17-rc1~31^2~48 X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=2ed912e9d35b4d7d766a530f5dd14513a3ab9f64;p=karo-tx-linux.git drbd: explicitly submit meta data requests with REQ_NOIDLE For some reason we have assumed NOIDLE was implied by one of the other flags we set. It is not (anymore?). Explicitly set REQ_NOIDLE for synchronous meta data updates, or we can seriously starve random writes when using CFQ. Signed-off-by: Philipp Reisner Signed-off-by: Lars Ellenberg --- diff --git a/drivers/block/drbd/drbd_actlog.c b/drivers/block/drbd/drbd_actlog.c index 278c31f24639..14b2f27291aa 100644 --- a/drivers/block/drbd/drbd_actlog.c +++ b/drivers/block/drbd/drbd_actlog.c @@ -150,7 +150,7 @@ static int _drbd_md_sync_page_io(struct drbd_device *device, if ((rw & WRITE) && !test_bit(MD_NO_FUA, &device->flags)) rw |= REQ_FUA | REQ_FLUSH; - rw |= REQ_SYNC; + rw |= REQ_SYNC | REQ_NOIDLE; bio = bio_alloc_drbd(GFP_NOIO); bio->bi_bdev = bdev->md_bdev;