From: Neil Armstrong Date: Tue, 1 Apr 2014 13:03:44 +0000 (+0200) Subject: Staging: silicom: fix dangerous if condition in bpctl_mod.c X-Git-Tag: next-20140428~14^2~154 X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=2f4285d17d3a5ae42e2811005dbcd4818d5d6ebe;p=karo-tx-linux.git Staging: silicom: fix dangerous if condition in bpctl_mod.c checkpatch script returns the following warning: ERROR: do not use assignment in if condition + if (((dev_num = get_dev_idx(dev->ifindex)) == -1) | This patch fixes the if condition by splitting it. Signed-off-by: Neil Armstrong Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/staging/silicom/bpctl_mod.c b/drivers/staging/silicom/bpctl_mod.c index 530d6214de74..7f3d884d4ddd 100644 --- a/drivers/staging/silicom/bpctl_mod.c +++ b/drivers/staging/silicom/bpctl_mod.c @@ -219,8 +219,12 @@ static int bp_device_event(struct notifier_block *unused, if (netif_carrier_ok(dev)) return NOTIFY_DONE; - if (((dev_num = get_dev_idx(dev->ifindex)) == -1) || - (!(pbpctl_dev = &bpctl_dev_arr[dev_num]))) + dev_num = get_dev_idx(dev->ifindex); + if (dev_num == -1) + return NOTIFY_DONE; + + pbpctl_dev = &bpctl_dev_arr[dev_num]; + if (!pbpctl_dev) return NOTIFY_DONE; if ((is_bypass_fn(pbpctl_dev)) == 1)