From: Lothar Waßmann <LW@KARO-electronics.de>
Date: Wed, 31 Jul 2013 14:21:15 +0000 (+0200)
Subject: usb: chipidea: don't clobber return value of ci_role_start()
X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=2fa79b80f2c12abdd91388931adcdcc14bd6a692;p=karo-tx-linux.git

usb: chipidea: don't clobber return value of ci_role_start()

If a role fails to start, propagate the error code up the call stack
from probe.

Signed-off-by: Lothar Waßmann <LW@KARO-electronics.de>
Signed-off-by: Alexander Shishkin <alexander.shishkin@linux.intel.com>
---

diff --git a/drivers/usb/chipidea/core.c b/drivers/usb/chipidea/core.c
index a5b3774bb223..2400b7f87f97 100644
--- a/drivers/usb/chipidea/core.c
+++ b/drivers/usb/chipidea/core.c
@@ -497,7 +497,6 @@ static int ci_hdrc_probe(struct platform_device *pdev)
 	ret = ci_role_start(ci, ci->role);
 	if (ret) {
 		dev_err(dev, "can't start %s role\n", ci_role(ci)->name);
-		ret = -ENODEV;
 		goto rm_wq;
 	}