From: Colin Ian King Date: Fri, 9 Sep 2016 08:31:54 +0000 (+0100) Subject: gpio: pca953x: initialize ret to zero to avoid returning garbage X-Git-Tag: v4.9-rc1~122^2~36 X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=313b9a9938bf4076425741121d5d766826793e5d;p=karo-tx-linux.git gpio: pca953x: initialize ret to zero to avoid returning garbage ret is not initialized so it contains garbage. Ensure garbage is not returned in the case that pdata && pdata->teardown is false by initializing ret to 0. Signed-off-by: Colin Ian King Signed-off-by: Linus Walleij --- diff --git a/drivers/gpio/gpio-pca953x.c b/drivers/gpio/gpio-pca953x.c index 5d059866d17a..f170c5678289 100644 --- a/drivers/gpio/gpio-pca953x.c +++ b/drivers/gpio/gpio-pca953x.c @@ -848,7 +848,7 @@ static int pca953x_remove(struct i2c_client *client) { struct pca953x_platform_data *pdata = dev_get_platdata(&client->dev); struct pca953x_chip *chip = i2c_get_clientdata(client); - int ret; + int ret = 0; if (pdata && pdata->teardown) { ret = pdata->teardown(client, chip->gpio_chip.base,