From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Mon, 14 Feb 2011 19:23:04 +0000 (-0800)
Subject: ipv4: fix rcu lock imbalance in fib_select_default()
X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=31d409373cca3517a30540b51f55dcb1f5af0d49;p=mv-sheeva.git

ipv4: fix rcu lock imbalance in fib_select_default()

Commit 0c838ff1ade7 (ipv4: Consolidate all default route selection
implementations.) forgot to remove one rcu_read_unlock() from
fib_select_default().

Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
---

diff --git a/net/ipv4/fib_semantics.c b/net/ipv4/fib_semantics.c
index 146bd82ef60..562f34cd930 100644
--- a/net/ipv4/fib_semantics.c
+++ b/net/ipv4/fib_semantics.c
@@ -1189,7 +1189,7 @@ void fib_select_default(struct fib_result *res)
 		fib_result_assign(res, last_resort);
 	tb->tb_default = last_idx;
 out:
-	rcu_read_unlock();
+	return;
 }
 
 #ifdef CONFIG_IP_ROUTE_MULTIPATH