From: Laurent Pinchart Date: Wed, 25 May 2011 11:43:53 +0000 (+0200) Subject: acornfb: Dont BUG() on invalid pan parameters X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=3846e93a65b1a127f59203606c0e92dd22f08782;p=mv-sheeva.git acornfb: Dont BUG() on invalid pan parameters The driver currently BUG()s if the pan parameters passed directly from userspace are invalid. Return -EINVAL instead. Signed-off-by: Laurent Pinchart --- diff --git a/drivers/video/acornfb.c b/drivers/video/acornfb.c index 6183a57eb69..3bacc129054 100644 --- a/drivers/video/acornfb.c +++ b/drivers/video/acornfb.c @@ -852,7 +852,8 @@ acornfb_pan_display(struct fb_var_screeninfo *var, struct fb_info *info) if (!(var->vmode & FB_VMODE_YWRAP)) y_bottom += var->yres; - BUG_ON(y_bottom > var->yres_virtual); + if (y_bottom > var->yres_virtual) + return -EINVAL; acornfb_update_dma(info, var);