From: Rui Miguel Silva Date: Fri, 30 Sep 2016 18:24:32 +0000 (+0100) Subject: staging: greybus: light: fix attributes allocation X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=3855eeec1a47cace93acd5ff89fb3c9bd593d307;p=linux-beck.git staging: greybus: light: fix attributes allocation Fix allocation of attributes with the correct size, this also fix smatch warning: drivers/staging/greybus/light.c:293 channel_attr_groups_set() warn: double check that we're allocating correct size: 8 vs 16 Signed-off-by: Rui Miguel Silva Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/staging/greybus/light.c b/drivers/staging/greybus/light.c index b2847feb7e86..f3cd48521af0 100644 --- a/drivers/staging/greybus/light.c +++ b/drivers/staging/greybus/light.c @@ -290,8 +290,7 @@ static int channel_attr_groups_set(struct gb_channel *channel, return 0; /* Set attributes based in the channel flags */ - channel->attrs = kcalloc(size + 1, sizeof(**channel->attrs), - GFP_KERNEL); + channel->attrs = kcalloc(size + 1, sizeof(*channel->attrs), GFP_KERNEL); if (!channel->attrs) return -ENOMEM; channel->attr_group = kcalloc(1, sizeof(*channel->attr_group),