From: Andrew Morton Date: Fri, 9 Nov 2012 03:04:55 +0000 (+1100) Subject: binfmt_elf-fix-corner-case-kfree-of-uninitialized-data-checkpatch-fixes X-Git-Tag: next-20121112~5^2~77 X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=385b4389853067f1166322aafefdf753cc16bebd;p=karo-tx-linux.git binfmt_elf-fix-corner-case-kfree-of-uninitialized-data-checkpatch-fixes WARNING: line over 80 characters #24: FILE: fs/binfmt_elf.c:1604: + info->psinfo.data = NULL; /* So we don't free this wrongly */ ERROR: code indent should use tabs where possible #26: FILE: fs/binfmt_elf.c:1606: + }$ WARNING: please, no spaces at the start of a line #26: FILE: fs/binfmt_elf.c:1606: + }$ total: 1 errors, 2 warnings, 11 lines checked NOTE: whitespace errors detected, you may wish to use scripts/cleanpatch or scripts/cleanfile ./patches/binfmt_elf-fix-corner-case-kfree-of-uninitialized-data.patch has style problems, please review. If any of these errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. Please run checkpatch prior to sending patches Cc: Alan Cox Signed-off-by: Andrew Morton --- diff --git a/fs/binfmt_elf.c b/fs/binfmt_elf.c index 1dc9b185e33d..0c42cdbabecf 100644 --- a/fs/binfmt_elf.c +++ b/fs/binfmt_elf.c @@ -1602,9 +1602,9 @@ static int fill_note_info(struct elfhdr *elf, int phdrs, psinfo = kmalloc(sizeof(*psinfo), GFP_KERNEL); if (psinfo == NULL) { - info->psinfo.data = NULL; /* So we don't free this wrongly */ + info->psinfo.data = NULL; /* So we don't free this wrongly */ return 0; - } + } fill_note(&info->psinfo, "CORE", NT_PRPSINFO, sizeof(*psinfo), psinfo);