From: Eric Dumazet <edumazet@google.com>
Date: Sun, 24 Jan 2016 21:53:50 +0000 (-0800)
Subject: af_unix: fix struct pid memory leak
X-Git-Tag: v4.4.14-KARO~1382
X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=39770be4d6ad29c5ab1f21edbbf01db067f13b52;p=karo-tx-linux.git

af_unix: fix struct pid memory leak

[ Upstream commit fa0dc04df259ba2df3ce1920e9690c7842f8fa4b ]

Dmitry reported a struct pid leak detected by a syzkaller program.

Bug happens in unix_stream_recvmsg() when we break the loop when a
signal is pending, without properly releasing scm.

Fixes: b3ca9b02b007 ("net: fix multithreaded signal handling in unix recv routines")
Reported-by: Dmitry Vyukov <dvyukov@google.com>
Signed-off-by: Eric Dumazet <edumazet@google.com>
Cc: Rainer Weikusat <rweikusat@mobileactivedefense.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---

diff --git a/net/unix/af_unix.c b/net/unix/af_unix.c
index e3f85bc8b135..775855ee1ff8 100644
--- a/net/unix/af_unix.c
+++ b/net/unix/af_unix.c
@@ -2332,6 +2332,7 @@ again:
 
 			if (signal_pending(current)) {
 				err = sock_intr_errno(timeo);
+				scm_destroy(&scm);
 				goto out;
 			}