From: David Daney Date: Wed, 19 Aug 2015 20:17:47 +0000 (-0700) Subject: of/address: Don't loop forever in of_find_matching_node_by_address(). X-Git-Tag: v4.3-rc1~108^2~5 X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=3a496b00b6f90c41bd21a410871dfc97d4f3c7ab;p=karo-tx-linux.git of/address: Don't loop forever in of_find_matching_node_by_address(). If the internal call to of_address_to_resource() fails, we end up looping forever in of_find_matching_node_by_address(). This can be caused by a defective device tree, or calling with an incorrect matches argument. Fix by calling of_find_matching_node() unconditionally at the end of the loop. Signed-off-by: David Daney Cc: stable@vger.kernel.org Signed-off-by: Rob Herring --- diff --git a/drivers/of/address.c b/drivers/of/address.c index 8bfda6ade2c0..384574c3987c 100644 --- a/drivers/of/address.c +++ b/drivers/of/address.c @@ -845,10 +845,10 @@ struct device_node *of_find_matching_node_by_address(struct device_node *from, struct resource res; while (dn) { - if (of_address_to_resource(dn, 0, &res)) - continue; - if (res.start == base_address) + if (!of_address_to_resource(dn, 0, &res) && + res.start == base_address) return dn; + dn = of_find_matching_node(dn, matches); }