From: Peter Griffin Date: Fri, 15 Aug 2014 12:40:11 +0000 (+0100) Subject: phy: phy-ti-pipe3: Remove unncessary site specific OOM messages X-Git-Tag: v3.18-rc1~131^2~19^2~17 X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=3a4cfcbbaf675eca0d6a3be224212a98cca60c2b;p=karo-tx-linux.git phy: phy-ti-pipe3: Remove unncessary site specific OOM messages The site specific OOM messages are unncessary, because they duplicate messages from the memory subsystem which include dump_stack(). Removing these superflous messages makes the kernel smaller. A discussion here http://patchwork.ozlabs.org/patch/324158/ found that all error paths from kzalloc will print a error message, and that any error path which maybe found which doesn't would be considered a bug in kzalloc. Signed-off-by: Peter Griffin Signed-off-by: Kishon Vijay Abraham I --- diff --git a/drivers/phy/phy-ti-pipe3.c b/drivers/phy/phy-ti-pipe3.c index b964aa967b46..9280ef8a05f5 100644 --- a/drivers/phy/phy-ti-pipe3.c +++ b/drivers/phy/phy-ti-pipe3.c @@ -299,10 +299,9 @@ static int ti_pipe3_probe(struct platform_device *pdev) struct clk *clk; phy = devm_kzalloc(&pdev->dev, sizeof(*phy), GFP_KERNEL); - if (!phy) { - dev_err(&pdev->dev, "unable to alloc mem for TI PIPE3 PHY\n"); + if (!phy) return -ENOMEM; - } + phy->dev = &pdev->dev; if (!of_device_is_compatible(node, "ti,phy-pipe3-pcie")) {